Skip to content

Bugfix for Hover which is visible above other application windows. #2534 #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

Bugfix for Hover which is visible above other application windows. #2534 #2540

merged 1 commit into from
Nov 27, 2024

Conversation

@mehmet-karaman
Copy link
Contributor

@mehmet-karaman mehmet-karaman commented Nov 25, 2024 •
edited
Loading

This patch is fixing the problem, where the HoverManagers listeners are deregistered but the hover is still visibile on top. This happens when the hover was sticky and after that eclipse was minimized and put back on foreground after it. In that case the listeners are already deregistered and there is no chance to react at all. So for this case the visibility has to be set explicitly when the close is going to stop.

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Nov 25, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From e1fa3eef6c6df538022dd7479817c6d7ad89d8ce Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 25 Nov 2024 15:30:48 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF b/bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
index f0f37e01f5..146f03a2a4 100644
--- a/bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jface.text
-Bundle-Version: 3.26.0.qualifier
+Bundle-Version: 3.26.100.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: 
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Test Results

 1 821 files  ±0   1 821 suites  ±0   2h 3m 49s ⏱️ - 1m 41s
 7 726 tests ±0   7 498 ✅ +3  228 💤 ±0  0 ❌  - 3 
24 339 runs  ±0  23 592 ✅ +3  747 💤 ±0  0 ❌  - 3 

Results for commit e6b3e28. ± Comparison against base commit 6a3eb35.

♻️ This comment has been updated with latest results.

@mehmet-karaman mehmet-karaman force-pushed the master branch 3 times, most recently from c85f6d4 to 970aff1 Compare November 26, 2024 11:35
iloveeclipse
iloveeclipse approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iloveeclipse
Copy link
Member

iloveeclipse commented Nov 26, 2024

@mehmet-karaman : I've verified last patch on Linux, have you verified it on Windows?

@mehmet-karaman @iloveeclipse
Bugfix for Hover which is visible above other application windows. ec…
e6b3e28 
…lipse-platform#2534

This patch is fixing the problem, where the HoverManagers listeners are
deregistered but the hover is still visibile on top. This happens when
the hover was sticky eclipse was minimized and put back on foreground
after it. THe shell visibility was set to false explicitly.

Originally the isVisible() was returning false and it won't be set to
visible explicitly.

Version bump(s) for 4.35 stream
@iloveeclipse
Copy link
Member

iloveeclipse commented Nov 26, 2024

Just rebased. jenkins had an OOM error while running ui tests. Surely not related to this change.

@HannesWell , @eclipse-platform/eclipsefdn-releng : are you aware about any environment changes for jenkins insances?

@HannesWell
Copy link
Member

HannesWell commented Nov 26, 2024

@HannesWell , @eclipse-platform/eclipsefdn-releng : are you aware about any environment changes for jenkins insances?

I'm not aware of any. Maybe this was just by chance. The latest build seem to have succeeded.

@mehmet-karaman
Copy link
Contributor Author

mehmet-karaman commented Nov 27, 2024 •
edited
Loading

@mehmet-karaman : I've verified last patch on Linux, have you verified it on Windows?

@iloveeclipse Yes, it works also on windows.

@iloveeclipse iloveeclipse merged commit d69caf3 into eclipse-platform:master Nov 27, 2024
17 checks passed
This was referenced Dec 2, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iloveeclipse iloveeclipse iloveeclipse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehmet-karaman @eclipse-platform-bot @iloveeclipse @HannesWell